ResNet Tests corrected for netfx - #2411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
==========================================
- Coverage 71.26% 71.22% -0.04%
==========================================
Files 785 786 +1
Lines 140869 140982 +113
Branches 16102 16116 +14
==========================================
+ Hits 100384 100413 +29
- Misses 36021 36098 +77
- Partials 4464 4471 +7
|
|
@Ivanidzo4ka @sfilipi @justinormont can you take a look at this PR ? |
|
Can we enable the DNNImage tests in this PR to verify if the fix works in the the netfx leg? It doesn't look like the DNNImage tests are part of the netfx test run currently. |
There is an already open PR by a contributor to remove all conditional attributes #2402 I have tested these tests locally by just removing the conditional fact attribute, if there is any fall out, i will add the commit in #2402 |
…oving the common code to a new helper funciton
|
@eerhardt @jignparm @justinormont I addressed the required feedback |
ghost
locked as resolved and limited conversation to collaborators
5 participants
Fixes #2373
The behavior of GetExecutingAssembly is different on netFramework. It return a temp path on .netFramework
This problem also occurred while enabling tests for netfx.